[Webkit-unassigned] [Bug 41888] Initial bindings and plumbing for IDBCursor.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 9 05:58:47 PDT 2010


--- Comment #4 from Andrei Popescu <andreip at google.com>  2010-07-09 05:58:47 PST ---
Looks good, some comments:

> WebCore/GNUmakefile.am

I think you have some tabs there or the indentation is wrong.

> WebCore/storage/IDBCursorRequest.idl

We don't have that in the spec anymore. I am not sure anymore what we're implementing, though...My suggestion would be to remove this altogether and only add a single IDL file, as per the spec.

// class IDBCursor
// ...
// PassRefPtr<IDBKeyRange> m_keyRange;

You don't want to store a PassRefPtr...make it a RefPtr?

>> PassRefPtr<IDBRequest> request() const;
>>     PassRefPtr<IDBAny> key() const;
 >>     PassRefPtr<IDBAny> value() const;

Why do these return PassRefPtr? Do we transfer ownership? If not, can they be raw pointers?

> class WebIDBKeyRange {
> WebIDBKeyRange(const WebIDBKeyRange& d) { m_private = d.m_private; }

I think you're supposed to use meaningful variable names instead of "d".

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list