[Webkit-unassigned] [Bug 24529] WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24529





--- Comment #79 from Michael Nordman <michaeln at google.com>  2010-07-09 00:36:14 PST ---
(From update of attachment 60992)
WebCore/inspector/InspectorApplicationCacheAgent.h:87
 +      void updateApplicationCacheStatus(int status);
I think the enumerated type here was better.

WebCore/inspector/front-end/ApplicationCacheItemsView.js:143
 +          if (!this._resources.length) {
Sounds like this *should* be testing the _manifest attribute, lets just leave it that way. I think your making this change in case getResourceList() has returned something but getAppCacheInfo() hasn't, is that right? But once these interfaces are working, that isn't a condition that should arise. Maybe there's some other reason?

WebCore/loader/appcache/ApplicationCacheHost.cpp:283
 +          if (!cache || !cache->isComplete())
this indent is off

WebKit/chromium/public/WebApplicationCacheHost.h:85
 +      virtual void getResourceList(WebApplicationCacheResourceInfoList* resources) { };
How about we put the webkit api changes can be in a separate patch so we get the right eyes to look at that one and to cover the cases we can reasonably anticipate.
new incoming interface on WebApplicationCacheHostClient
- onCacheSelected
new outgoing interfaces on WebApplicationCacheHost
- getResources
- deleteCacheGroup  // pretty clear we'll want this


WebKit/chromium/WebKit.gyp:87
 +                  'public/WebApplicationCacheResourceInfoList.h'
seperate patch?

WebKit/chromium/src/ApplicationCacheHost.cpp:239
 +      }
We should just put a FIXME here for now. When we have the webkit api in place and functional enough (on the chrome side) to not break the UI, we can return real data to populate the UI.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.