[Webkit-unassigned] [Bug 39702] JavaScriptCore threading relies on QApplication existing

Thu Jul 8 23:46:28 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39702

Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58663|review?                     |review-
               Flag|                            |

--- Comment #8 from Simon Hausmann <hausmann at webkit.org>  2010-07-08 23:46:28 PST ---
(From update of attachment 58663)
The patch/bug doesn't explain what the actual issue is that this fixes, beyond "it's better to make sure..."

The ChangeLog is also slightly malformed, the "Reviewed by" should be at the top.

Anders, I'm okay with the patch in principle, but it would really help to understand your motivation behind the change. Imagine a year down the line trying to figure out why this was changed ...

r- because of the missing explanation and malformed ChangeLog. The patch itself is okay, once we know what it really fixes :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.