[Webkit-unassigned] [Bug 41895] [MathML] Implement mathcolor and mathbackground attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41895


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60957|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-07-08 14:38:13 PST ---
(From update of attachment 60957)
WebCore/mathml/MathMLElement.cpp:4
 +   * Copyright (C) 2010 François Sausset (sausset at gmail.com). All rights reserved.
There seems to be some unicode issues here.

 62     if (attr->name() == MathMLNames::mathcolorAttr) {
 63         addCSSProperty(attr, CSSPropertyColor, attr->value());
 64     } else if (attr->name() == MathMLNames::mathbackgroundAttr) {
 65         addCSSProperty(attr, CSSPropertyBackgroundColor, attr->value());
 66         
 67     } else
 68         StyledElement::parseMappedAttribute(attr);

These one liners should not have braces. There is also a strange newline before the last else.

Apart from this the patch looks fine. Please fix these things before committing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.