[Webkit-unassigned] [Bug 41384] Allow Chromium access to Select control choices

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41384


James Hawkins <jhawkins at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jhawkins at chromium.org




--- Comment #4 from James Hawkins <jhawkins at chromium.org>  2010-07-08 12:58:58 PST ---
(In reply to comment #3)
> (From update of attachment 60150 [details])
> WebKit/chromium/src/WebSelectElement.cpp:65
>  +  
> nit: only one new line
> 
> WebKit/chromium/src/WebSelectElement.cpp:60
>  +              items[i] = static_cast<HTMLOptionElement*>(sourceItems[i])->value();
> instead of returning a list of the values of the items, how
> about returning WebOptionElement objects instead?  otherwise,
> i think the name of this method should be listItemValues to
> better correspond to what it is returning.
> 
> WebOptionElement seems better to me.

I agree. Implementing WebOptionElement is ideal.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.