[Webkit-unassigned] [Bug 32605] Regression: Selection anchor + focus swap when arrow keys after setBaseAndExtent
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 8 11:59:00 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=32605
--- Comment #18 from Ojan Vafai <ojan at chromium.org> 2010-07-08 11:59:00 PST ---
(In reply to comment #17)
> (From update of attachment 60917 [details])
> I’d rather see the enum at the global level rather than as a member. I don’t think there’s any real danger of conflict with other similar enums.
>
> I think we could find a better name for the enum by talking about what it is and selecting words from that discussion. For example we could consider using verbs like “MakeNonDirectionalSelection” and “MakeDirectionalSelection”. The word “policy” in the name of the enum allows the enum values to be verbs instead of adjectives or nounds.
>
> Fine as-is, though. r=me
Thanks. Both of those sound good to me. I'll change the enum to the following and commit:
enum DirectionalityPolicy { MakeNonDirectionalSelection, MakeDirectionalSelection };
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list