[Webkit-unassigned] [Bug 41779] [GTK] Implement ImageDiff and add it to the build system

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41779





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2010-07-08 11:24:09 PST ---
(In reply to comment #4)

Thanks for the review!

> Given that you never use the diffBuffer as a void*, I would prefer having
> the cast in the malloc call, it makes it a bit easier on the reader of the
> code.

Okay, will fix.

> I find the mixed usage of g_print, fputs and fprintf unnecessary,
> though I do not oppose to it. I feel like you cal also make the ifs
> that are under the else ifs here be just one more condition of the else if:

Okay, I'll switch it to all (f)printf.

> 
>  206             if (imageSize > 0 && !actualImage) {
>  207                 if (!(actualImage = readPixbufFromStdin(imageSize))) {
>  208                     fputs("Error, could not read actual image.\n", stdout);
>  209                     return 1;
>  210                 }
>  211             } else if (imageSize > 0 && !baselineImage) {
>  212                 if (!(baselineImage = readPixbufFromStdin(imageSize))) {
>  213                     fputs("Error, could not read baseline image.\n", stdout);
>  214                     return 1;
>  215                 }

I think this has to stay. I want to actually bail out if the image fails
to load, but I don't want to bail out if the first condition fails.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.