[Webkit-unassigned] [Bug 41721] Missing plug-in indicator button should have a pressed state

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 8 09:15:17 PDT 2010


--- Comment #5 from Adam Roben (aroben) <aroben at apple.com>  2010-07-08 09:15:17 PST ---
(From update of attachment 60834)
You need to update UIDelegate::QueryInterface to support querying to IWebUIDelegatePrivate3. You should probably support IWebUIDelegatePrivate2, too.

You could get away without adding shouldMissingPluginMessageBeButton on Windows. You could instead say "if the UI delegate implements IWebUIDelegatePrivate3, then the message should be a button". That would be good enough for Safari. It's not clear to me whether that's better than adding the new delegate function, though.

Other than that, the Windows changes look fine.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list