[Webkit-unassigned] [Bug 41790] Make FastMalloc more portable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 8 03:53:41 PDT 2010


--- Comment #9 from Mark Rowe (bdash) <mrowe at apple.com>  2010-07-08 03:53:40 PST ---
ThreadSpecific.h allocates memory using FastMalloc, so it can’t be used within FastMalloc’s implementation.  It didn’t appear to be used by the attached patch anyway, so maybe that’s besides the point.

I don’t think Threading.h is the right header to include.  The data types used all seem to come from ThreadingPrimitives.h, so why not include that instead?

I’m also wary of introducing WTF types in to FastMalloc.  Many bits of code in WTF allocate memory in order to do their job, which isn’t something that’s sensible to do via the normal means from within the memory allocator.  WTF::createThread is one such function.

I’m curious why this weird subset of FastMalloc was modified in this manner.  There’s a bunch of other code in FastMalloc that uses pthreads after all.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list