[Webkit-unassigned] [Bug 41518] Speech input plumbing in webcore and webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41518





--- Comment #9 from Steve Block <steveblock at google.com>  2010-07-08 03:08:17 PST ---
> Testing was one of the main reasons, since there was a need to enable the
> mock SpeechInputClient when a layout test's JS code says so. Was your
> suggestion to always use the mock SpeechInputClient in LayoutTestController?
Yes, or alternatively the embedder can respond to LayoutTestController calls and modify their own SpeechInputClient to mock things appropriately.

> However, the other reason was the growing number of arguments to the
> constructor (8 already) and some of the clients passed in as null by majority
> of the callers.
Makes sense

> Effectively the SpeechInput class is the controller here, though there are
> multiple instances of it.
Makes sense

This patch looks fine to me. The decision on the last two points above are, I think, policy decisions about how closely we want to adhere to existing patterns. I don't think I have enough WebKit experience to make these decisions, so it would be good if Sam or somebody else with the necessary background could give the r+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.