[Webkit-unassigned] [Bug 24529] WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24529





--- Comment #72 from Michael Nordman <michaeln at google.com>  2010-07-07 20:32:47 PST ---
(In reply to comment #69)
> > Yes, we had gravitated away from that after seeing how little was required in the ACH class.
> > To fork another file is to fork more, not less. We came to see that InspectorApplicationCacheAgent
> > could be shared code and were pressing down that path.
> 
> I was never made aware of this.

It was reflected in the Kavita's patch.

> Reverting the patches leaves me with the same problem from before.

What problem is that?

> As I understand it,
> Chromium is not broken in any way. It builds and AppCache works, it just don't have support
> for the inspector. It was expected (from Kativa's patch above) to land as a separate patch
> anyways. I can move the functions back to ApplicationCacheHost, but in all cases Chromium
> is going to have to land a separate patch.

I was asking you to consider reverting not so much because of the chrome issues, that can be patched one way or the other. I'm more concerned about unasked questions regarding other aspects of the patch.

- When a page calls swapCache and gets associated with a new cache, how does the display get updated? What interface does the 'backend' call to prod the 'frontend' into realizing that something has changed? Kavita was calling this interface applicationCacheSelected() and had it as a method on the inspector controller.

- When multiple top-level pages are associated with the same appcache group, it looks like only one (actually could be none) will be notified of update status changes, what about the others? I'm not talking about the nested frames, multiple pages using the same cache. What is your plan for that?

- Can you separate populating the list view on the left-hand-side from the detailed grid view on the right-hand-side and defer fetching the resource list until needed? That could help make the interface more responsive.

- How does InspectorApplicationCacheAgent::didReceiveManifestResponse figure out which appcache/appcacheHost its being called by? Same question for all interfaces related to "pushing" info from the backend to the frontend. What is the plan for that?

- Why is 'domain' used as the label in the left-hand-side? The cookie model doesn't really apply, there can be multiple application caches per domain and in use in the same page at the same time. This real estate could probably be put to better use than having the 'domain' on display.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.