[Webkit-unassigned] [Bug 41669] [Chromium] Upstreaming inspector_resources target

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41669





--- Comment #5 from Kent Tamura <tkent at chromium.org>  2010-07-07 19:23:57 PST ---
Thank you for looking at the patch.

(In reply to comment #3)
> WebKit/chromium/WebKit.gyp:68
>  +          'debug_devtools%': 0,
> Nit: It would be nice if there was a comment describing what this does.

Added a comment.

> WebKit/chromium/WebKit.gyp:562
>  +              # 'msvs_guid': '5330F8EE-00F5-D65C-166E-E3150171055D',
> Can we just remove this?

Removed.  According to http://code.google.com/p/gyp/wiki/GypUserDocumentation#Skeleton_of_a_typical_executable_target_in_a_.gyp_file, we don't need msvs_guid anymore, right?

> WebKit/chromium/WebKit.gyp:566
>  +                      'dependencies+': ['concatenated_devtools_js'],
> What does the + at the end do?

Prepending something to 'dependencies' makes no sense.  I removed '+'.

> WebKit/chromium/WebKit.gyp:578
>  +                              'files/': [['exclude', '\\.js$']],
> What does the / at the end of files do?

I think we need to use pattern exclusion here.
http://code.google.com/p/gyp/wiki/InputFormatReference#Pattern_Lists_(/)

> WebKit/chromium/WebKit.gyp:599
>  +                      '<(chromium_src_dir)/webkit/build/generate_devtools_html.py',
> Can we upstream generate_devtools_html.py too?

We can.  Where should we put it to?  WebKitTools/Scripts?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.