[Webkit-unassigned] [Bug 24529] WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24529





--- Comment #69 from Joseph Pecoraro <joepeck at webkit.org>  2010-07-07 17:46:14 PST ---
> Yes, we had gravitated away from that after seeing how little was required in the ACH class.
> To fork another file is to fork more, not less. We came to see that InspectorApplicationCacheAgent
> could be shared code and were pressing down that path.

I was never made aware of this.


> I would say that the #if CHROMIUMs that you actually have put in place are very messy.

These were to prevent the build from breaking. Now that the build is fine, its time to
write the Chromium side of this.


> Pavel mentioned something earlier about "how WebKit works". From what I've seen in the past,
> patches get reverted if there are valid issues raised.
> [...] Would you consider reverting these patches. They really were not sufficiently reviewed.

Reverting the patches leaves me with the same problem from before.  As I understand it,
Chromium is not broken in any way. It builds and AppCache works, it just don't have support
for the inspector. It was expected (from Kativa's patch above) to land as a separate patch
anyways. I can move the functions back to ApplicationCacheHost, but in all cases Chromium
is going to have to land a separate patch.

If something is really broken, than I will consider rolling this out, if that is easier that
patching it.

I can attach a patch moving these functions to ApplicationCacheHost that you can
incorporate into a Chromium patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.