[Webkit-unassigned] [Bug 38693] cleanup json_results_generator dependencies so that non-layout-tests can also use it safely

Wed Jul 7 15:01:20 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=38693

Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59954|review?                     |review+
               Flag|                            |

--- Comment #20 from Ojan Vafai <ojan at chromium.org>  2010-07-07 15:01:19 PST ---
(From update of attachment 59954)
Thanks for following up with this. Please fix the nits below before committing.

WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:190
 +          PASS_RESULT, NO_DATA_RESULT and etc) that indicates the test result
nit: Common style for this would be the following (no "and"):
PASS_RESULT, NO_DATA_RESULT, etc)

WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:451
 +  # Please keep the interface until the other script is cleaned up.
Nit: This should probably be phrased as a FIXME. Something like:
# FIXME: Remove this interface once the other script is cleaned up.

Also, a link pointing to the other script (e.g. in src.chromium.org) wouldn't hurt.

WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:42
 +  class JSONGenerationTest(unittest.TestCase):
How about calling this JSONResultsGeneratorTest?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.