[Webkit-unassigned] [Bug 41576] [chromium] Fix drawing of inset box shadows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41576





--- Comment #6 from Adam Langley <agl at chromium.org>  2010-07-07 08:36:14 PST ---
(In reply to comment #5)
> but this patch makes that comment false and illustrates why having this method is a bad idea. Moreover, the change log (which mentions a bunch of files that the patch doesn’t touch) does a very poor job of explaining the change.

The point of canvas clip was that anti-aliased clipping causes seams when attempting to join two polygons. So the canvas folks didn't want it on by default, but everyone else was calling for my blood over anti-aliased rounded corners.

I'm afraid that the ChangeLog here is insufficient to understand the problem. Why does the layered clipping fail?

> I suggest eliminating canvasClip() and devising a better solution to the platform-specific problem it was intended to solve; ideally, such a solution will not require people writing cross-platform code to have to think about the platform-specific problem. As things stand, there is no way for someone writing rendering code to tell whether they should call clip() or canvasClip().

Possibly canvasClip should have been called aliasedClip. However, it's very easy to tell if you should be calling canvasClip: if you're not rendering to a <canvas> element then you shouldn't.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.