[Webkit-unassigned] [Bug 41669] [Chromium] Upstreaming inspector_resources target

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41669





--- Comment #3 from Tony Chang (Google) <tony at chromium.org>  2010-07-07 08:30:08 PST ---
(From update of attachment 60605)
I realize that this is mostly a copy/paste from the existing gyp file, but might as well clean up the code a bit.

WebKit/chromium/WebKit.gyp:68
 +          'debug_devtools%': 0,
Nit: It would be nice if there was a comment describing what this does.

WebKit/chromium/WebKit.gyp:562
 +              # 'msvs_guid': '5330F8EE-00F5-D65C-166E-E3150171055D',
Can we just remove this?

WebKit/chromium/WebKit.gyp:566
 +                      'dependencies+': ['concatenated_devtools_js'],
What does the + at the end do?

WebKit/chromium/WebKit.gyp:578
 +                              'files/': [['exclude', '\\.js$']],
What does the / at the end of files do?

WebKit/chromium/WebKit.gyp:599
 +                      '<(chromium_src_dir)/webkit/build/generate_devtools_html.py',
Can we upstream generate_devtools_html.py too?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.