[Webkit-unassigned] [Bug 41685] DeviceOrientationEventConstructor should be exposed at window.DeviceOrientationEvent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 7 03:16:28 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=41685


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60616|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Adam Barth <abarth at webkit.org>  2010-07-07 03:16:28 PST ---
(From update of attachment 60616)
The code looks right.  A couple questions about the tests.

LayoutTests/fast/dom/Window/window-properties-device-orientation.html:34
 +      if (typeof value == "object" && value == null) //;
Why "//;" here?

LayoutTests/fast/dom/Window/window-properties.html:86
 +      "window.DeviceOrientationEvent" : 1,
Why skip this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list