[Webkit-unassigned] [Bug 41592] ProgressTracker looks not smart

Wed Jul 7 02:30:27 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=41592

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60705|review?                     |review-
               Flag|                            |

--- Comment #3 from Adam Barth <abarth at webkit.org>  2010-07-07 02:30:27 PST ---
(From update of attachment 60705)
Thanks for the patch, but a number of things are unclear to me:

WebCore/loader/ProgressTracker.cpp:184
 +      if (frame->loader()->client())
Do we need to null-check the client here?  Is the client disappearing somehow?

WebCore/loader/ProgressTracker.cpp: 
 +      // FIXME: Can this ever happen?
Did we resolve this FIXME?  It might be worth explaining when item might be NULL.

In general, we would like to see a test with each patch.  Is there a way to test this code change?  I'm not 100% sure this is the right direction.  It's difficult to tell from this bug report and from the ChangeLog exactly what problem we're solving here.  It's also unclear to me how this change effects all the different clients of resource load notifier.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.