[Webkit-unassigned] [Bug 41348] Remove global variables from XSLTProcessorLibxslt.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 6 09:49:54 PDT 2010


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #60634|review?                     |review+
               Flag|                            |

--- Comment #11 from Alexey Proskuryakov <ap at webkit.org>  2010-07-06 09:49:54 PST ---
(From update of attachment 60634)
> +    // m_sourceNode is set (and reset) in the transformToString function
> +    // so that the libxslt loader callback can access the source node
> +    // of the transformation
> +    Node* m_sourceNode;

This seems too wordy (of course m_sourceNode is the source node), and doesn't directly explain why this needn't be a RefPtr. I suggest something like "Source node is only non-null in transformToString(), so this cannot become a dangling pointer".

> +    // Save a pointer to the stylesheet so that we can access it from the libxslt loader callback

Comments are full sentences, and should end with a period.


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list