[Webkit-unassigned] [Bug 41597] Don't pass image hash to DRT when pixel tests are disabled
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 6 02:18:29 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=41597
--- Comment #4 from Csaba Osztrogonac <ossy at webkit.org> 2010-07-06 02:18:28 PST ---
(In reply to comment #2)
> (From update of attachment 60510 [details])
> Does this match old-run-webkit-tests? Why is Qt the only port which has noticed this? (Because other ports aren't using NRWT much yet?)
ORWT only pass hash to DRT if pixel tests is enabled:
------
# Try to read expected hash file for pixel tests
my $suffixExpectedHash = "";
if ($pixelTests && !$resetResults) {
my $expectedPixelDir = expectedDirectoryForTest($base, 0, "png");
if (open EXPECTEDHASH, "$expectedPixelDir/$base-$expectedTag.checksum") {
my $expectedHash = <EXPECTEDHASH>;
chomp($expectedHash);
close EXPECTEDHASH;
# Format expected hash into a suffix string that is appended to the path / URL passed to DRT
$suffixExpectedHash = "'$expectedHash";
}
}
------
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list