[Webkit-unassigned] [Bug 41644] New: rebaseline-chromium-webkit-tests: wrong dup detection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41644

           Summary: rebaseline-chromium-webkit-tests: wrong dup detection
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tkent at chromium.org
                CC: hamaji at chromium.org, victorw at chromium.org,
                    morrita at google.com


If an image expectation for Linux and an image expectation for Windows are *similar*, the Linux expectation imae is unexpectedly removed.

How to repeat:
 Rebaseline Linux and Windows expectation on Mac Leopard
1. build ImageDiff (build-webkit and build-dumprendertree)
2. prepend "REBASELINE" to the following line in test_expectations.txt
  BUG48154 WIN LINUX: fast/forms/indeterminate.html = IMAGE
3. run "rebaseline-chromium-webkit-tests -w"

Expected result:
  Because the Linux image and the Windows image are different, I expect
   LayoutTests/platform/chromium-win/fast/forms/indeterminate-expected.checksum
   LayoutTests/platform/chromium-win/fast/forms/indeterminate-expected.png
   LayoutTests/platform/chromium-linux/fast/forms/indeterminate-expected.checksum
   LayoutTests/platform/chromium-linux/fast/forms/indeterminate-expected.png
are updated.

Actual result:
   LayoutTests/platform/chromium-win/fast/forms/indeterminate-expected.checksum
   LayoutTests/platform/chromium-win/fast/forms/indeterminate-expected.png
   LayoutTests/platform/chromium-linux/fast/forms/indeterminate-expected.checksum
are updated, and 
   LayoutTests/platform/chromium-linux/fast/forms/indeterminate-expected.png
is removed.

Log:
100706 12:14:27 rebaseline_chromium_webkit_tests.py:154 INFO ------------------ Extracting and adding new baselines: linux ------------------
100706 12:14:27 rebaseline_chromium_webkit_tests.py:423 INFO Test 1: fast/forms/indeterminate.html
100706 12:14:27 rebaseline_chromium_webkit_tests.py:434 INFO   .txt file not in archive.
100706 12:14:27 rebaseline_chromium_webkit_tests.py:438 INFO   .png file found in archive.
100706 12:14:27 rebaseline_chromium_webkit_tests.py:527 INFO   Found same baseline at /Users/tkent/WebKit/LayoutTests/platform/chromium-win/fast/forms/indeterminate-expected.png
100706 12:14:28 rebaseline_chromium_webkit_tests.py:438 INFO   .checksum file found in archive.
100706 12:14:29 rebaseline_chromium_webkit_tests.py:487 INFO   Rebaseline succeeded.

Root cause:
rebaseline-chromium-webkit-tests uses diff_image() in layout_tests_port/webkit.py, and it pass "--torelance 0.1" to ImageDiff.
So diff_image() returns False if the difference between two images are small,

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.