[Webkit-unassigned] [Bug 41149] [EFL] Implement downloadURL in ContextMenuClientEfl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41149





--- Comment #9 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-07-05 18:51:53 PST ---
(In reply to comment #8)
> Should I remove url argument in virtual void downloadURL(const KURL& url); ?
> 
> I referenced to gtk / qt port.
> 
> ContextMenuClientGtk.h
> => virtual void downloadURL(const WebCore::KURL& url);
> 
> ContextMenuClientQt.h
> => virtual void downloadURL(const KURL& url);

Don't trust old code :-) For method definitions you should leave our duplicate information. I already know it is an url as the type is KURL, same think with setText(const String&) is better than setText(const String& string) as string doesn't add additional info. On the other hand, if it is not duplicating info feel free to add it, like setLabel(const String& label, const String& tooltip). Got it?

Qt specific code used to follow Qt style, but we will clean that up over time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.