[Webkit-unassigned] [Bug 41461] Web Inspector: all breakpoints are activated on page reload

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41461





--- Comment #6 from Pavel Podivilov <podivilov at chromium.org>  2010-07-05 11:26:46 PST ---
(In reply to comment #4)
> (From update of attachment 60511 [details])
> LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload.html:75
>  +   * Checks that all expected scripts are present in the scripts list
> You don't need to port these comments.
> 
> WebCore/inspector/front-end/ScriptsPanel.js:614
>  +          if (!options)
> I's rather change this to options = options || {};
> 
> LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload.html:164
>  +  Tests that breakpoints are not activated on page reload.
> We usually put link to a bug in test descriptions.
> 
> LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload.html:125
>  +  function frontend_showMainPageScriptSource(scriptName, callback)
> frontend_showScriptSource would better reflect what it does since it doesn't
> use the fact that scriptName is the name of the main resource.
> 
> LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload.html:145
>  +          WebInspector.currentPanel._showScriptOrResource(scriptResource);
> Use scriptsPanel instead of WebInspector.currentPanel as you do below.
Done.

> 
> LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload.html:27
>  +      var testName = "debugger-breakpoints-not-activated-on-reload.html";
> You can get the test name from document.location
I'm not sure how to grab document.location from inspected page, so I've used
WebInspector.mainResource.url instead.

> LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload.html:58
>  +              testController.notifyDone();
> You need to wait until all scripts are pushed to the front-end again, right?
> r- for that.
This code is called only after main script with breakpoint is parsed, it should
be enough.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.