[Webkit-unassigned] [Bug 41606] Refactored string parsing in the lexer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41606





--- Comment #5 from Zoltan Herczeg <zherczeg at webkit.org>  2010-07-05 06:40:05 PST ---
Hm, maybe I have an idea what is causing the slowdown. The original code, there was two makeIdentifier call. I did a few changes before, and realized I removed one of them (one was for a fast path when the m_buffer was not needed). I put it back (thought it was a stupid move), and the slowdown appeared again. Later I refactored the code, that even though I keep the fast case, only one makeIdentifier appeared in the code, and the speed was nearly as fast as the patch added to this bug. Maybe the ALWAYS_INLINE makeIdentifier is more computation expensive than I expected... at least on my machine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.