[Webkit-unassigned] [Bug 24529] WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24529


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60500|                            |review?
               Flag|                            |




--- Comment #56 from Joseph Pecoraro <joepeck at webkit.org>  2010-07-05 01:20:21 PST ---
Created an attachment (id=60500)
 --> (https://bugs.webkit.org/attachment.cgi?id=60500)
[PATCH] Part 2: Pulling ApplicationCache Resources to Display in the Inspector.

> WebCore/inspector/InspectorApplicationCacheAgent.cpp:72
>  +      ApplicationCacheHost* host = m_inspectorController->inspectedPage()->mainFrame()->loader()->documentLoader()->applicationCacheHost();
> How about you cache documentLoader in a var above?

Done.


> WebCore/inspector/InspectorApplicationCacheAgent.cpp:117
>  +          types.append("Master ");
> Looks like localizable names to me. Todo?

Hmm, yes I'll add a follow up patch to see if this is desired. Good catch.


> WebCore/loader/appcache/ApplicationCacheHost.cpp:246
>  +  void ApplicationCacheHost::fillResourceList(InspectorApplicationCacheAgent::ResourceInfoList* resources)
> This I don't like at all. I believe inspector controller functionality should be encapsulated.
> We should not force instrumented code to be too involved with the inspector controller.
> [...] Or even better, add public applicationCacheForInspector method that would call
> applicationCache(). And use it from the agent. In a sense, that's what you are doing in this method.

Done.


> Btw, put the Google copyright in case you are using her code

Done.

Added Kativa to the ChangeLog and added copyright to InspectorApplicationCacheAgent.cpp
for the implementation of the buildObject/Array methods, and other functions. Updated
copyright in DOMAgent.js. All other files had minor changes or were up to date.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.