[Webkit-unassigned] [Bug 24529] Add support in Web Inspector for examining/changing data for HTML5 offline-Web-applications (application cache)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 4 11:46:53 PDT 2010


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #54234|0                           |1
        is obsolete|                            |
  Attachment #60170|0                           |1
        is obsolete|                            |
  Attachment #60289|0                           |1
        is obsolete|                            |

--- Comment #46 from Joseph Pecoraro <joepeck at webkit.org>  2010-07-04 11:46:52 PST ---
Created an attachment (id=60474)
 --> (https://bugs.webkit.org/attachment.cgi?id=60474)
[PATCH] Dump of All Changes - To Be Broken Down

@Reviewers: I intend to break this down into numerous parts. I'm thinking two,
because a lot is boilerplate and easy to follow, but I might make it 3 patches if
I can find a sweetspot. However, feel free to provide comments in the meantime.

@Kavita, I applied the patch locally, got it building, and made some improvements.
In order to get this building I had to do a _lot_ of work. There were a number of
files in my patch which were missing in this patch! InspectorApplicationCacheAgent
for instance. Numerous build files were neglected, which appeared in my patch,
and plenty of other small things (images, localizedStrings, ...).

One more thing. Your patch had some seriously messed up whitespace! Including
in the JavaScript file where whole sections were wildly formatted. Please be aware
of this in the future, and set your editor up to more closely match WebKit's style.

Changes you need to know:
  - moved all the new structs to InspectorApplicationCacheAgent
  - moved the "ApplicationCacheInfo" handling to InspectorApplicationCacheAgent
  - renamed some (still not all) "AppCache" and "Appcache" to "ApplicationCache"

Proposed Followup Fixes in Separate Bugs:
  - WebKit: Show ApplicationCache resource data in Resources Panel
  - WebKit: Add ApplicationCache "Creation Time" and "Update Time"
  - Show ApplicationCache resources differently in Resources Panel"
  - Better handle multiple manifests, such as multiple <iframe>s
  - Hook Up "Referesh" and "Delete" buttons in ApplicationCache DataGrid
  - Only show "APPLICATION CACHE" section in Storage when one exists
  - Refactor: drop "get" from "getCookies" and "getApplicationCache"

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list