[Webkit-unassigned] [Bug 41576] [chromium] Fix drawing of inset box shadows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41576


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60467|review?                     |review-
               Flag|                            |




--- Comment #5 from mitz at webkit.org  2010-07-04 09:56:22 PST ---
(From update of attachment 60467)
A method called GraphicsContext::canvasClip() sounds like a bad idea. According to GraphicsContext.h,

// This clip function is used only by <canvas> code

but this patch makes that comment false and illustrates why having this method is a bad idea. Moreover, the change log (which mentions a bunch of files that the patch doesn’t touch) does a very poor job of explaining the change.

I suggest eliminating canvasClip() and devising a better solution to the platform-specific problem it was intended to solve; ideally, such a solution will not require people writing cross-platform code to have to think about the platform-specific problem. As things stand, there is no way for someone writing rendering code to tell whether they should call clip() or canvasClip().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.