[Webkit-unassigned] [Bug 41529] Add the ability for user scripts and user styles to affect just the top frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41529





--- Comment #6 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-07-02 22:18:49 PST ---
(From update of attachment 60405)
WebKit/chromium/public/WebView.h:58
 +      enum WebUserScriptInjectionTime {
The Web-prefix is for things defined at WebKit-namespace scope.  When
declared within a class, you should drop the Web-prefix.

We also have the convention that enum values should be formed like so:

enum Foo {
  FooBar,
  FooBaz
};

I realize that may be a bit verbose for these.

  enum UserScriptInjectionTime {
    UserScriptInjectionTimeAtDocumentStart,
    UserScriptInjectionTimeAtDocumentEnd
  };

  enum UserScriptInjectedFrames {
    UserScriptInjectedFramesAll,
    UserScriptInjectedFramesTopOnly
  };

^^^ That last one is especially awkward.  I'm not sure what would be
better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.