[Webkit-unassigned] [Bug 41548] Use snprintf instead of sprintf everywhere in JavaScriptCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 2 16:28:26 PDT 2010


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
  Attachment #60417|                            |commit-queue-
               Flag|                            |

--- Comment #4 from Darin Adler <darin at apple.com>  2010-07-02 16:28:26 PST ---
(From update of attachment 60417)
JSGlobalObjectFunctions.cpp includes <string.h>, but now that it's using snprintf I think it needs to include StringExtras.h instead to avoid breaking the Windows build.

review+ if you fix that.

Also: UString::from(long long) uses snprintf, and for some reason passes sizeof(minBuf) - 1. WTF is up with that?

And: UString.cpp seems to include StringExtras.h twice and also includes <string.h> unnecessarily since StringExtras.h includes that.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list