[Webkit-unassigned] [Bug 41510] Add ignoreWhitespace option at base64Decode()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41510


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60348|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2010-07-02 12:02:46 PST ---
(From update of attachment 60348)
> What is the best way to do a LayoutTest for the change in Page.cpp? Example?

It would help if ChangeLog explained the change.

There is a number of calls for user style sheet manipulation in layoutTestController, such as addUserStyleSheet, clearPersistentUserStyleSheet, setPersistentUserStyleSheetLocation, setUserStyleSheetEnabled, setUserStyleSheetLocation.

+    if (!base64Decode(in, out, false)) {

The person reading this code will have no idea about what "false" means. Please use a named enum constant instead.

r- for lack of testing and ChangeLog explanation. I didn't check the actual math.

See also: loosely related bug 23566.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.