[Webkit-unassigned] [Bug 41522] New: GTK build fails when [Conditional=FEATURE] tags used in .idl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41522

           Summary: GTK build fails when [Conditional=FEATURE] tags used
                    in .idl
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: johnnyg at google.com
                CC: jianli at chromium.org


If a IDL file uses the [Conditional=FEATURE] tag on a specific attribute, the GTK build fails.

Example patch (see bug 40872)

Index: WebCore/html/File.idl
===================================================================
--- WebCore/html/File.idl    (revision 62339)
+++ WebCore/html/File.idl    (working copy)
@@ -30,6 +30,7 @@ module html {
         GenerateToJS
     ] File : Blob {
         readonly attribute DOMString name;
+        readonly attribute [Conditional=DIRECTORY_UPLOAD] DOMString path;

         // FIXME: obsolete attributes. To be removed.
         readonly attribute DOMString fileName;
Index: WebCore/html/HTMLInputElement.idl
===================================================================
--- WebCore/html/HTMLInputElement.idl    (revision 62339)
+++ WebCore/html/HTMLInputElement.idl    (working copy)
@@ -40,6 +40,7 @@ module html {
         attribute long maxLength setter raises(DOMException);
         attribute [Reflect] DOMString min;
         attribute [Reflect] boolean multiple;
+        attribute [Reflect, Conditional=DIRECTORY_UPLOAD] boolean webkitdirectory;
         attribute [Reflect] DOMString name;
         attribute [Reflect] DOMString pattern;
         attribute [Reflect] DOMString placeholder;

Generated these errors:

In file included from ./DerivedSources/webkit/webkitdom.h:49,
                 from ../../WebKit/gtk/webkit/webkit.h:26,
                 from ../../WebKitTools/GtkLauncher/main.c:28:
./DerivedSources/webkit/WebKitDOMFile.h:52:5: warning: "ENABLE" is not defined
./DerivedSources/webkit/WebKitDOMFile.h:52:11: error: missing binary operator before token "("
In file included from ./DerivedSources/webkit/webkitdom.h:80,
                 from ../../WebKit/gtk/webkit/webkit.h:26,
                 from ../../WebKitTools/GtkLauncher/main.c:28:
./DerivedSources/webkit/WebKitDOMHTMLInputElement.h:163:5: warning: "ENABLE" is not defined
./DerivedSources/webkit/WebKitDOMHTMLInputElement.h:163:11: error: missing binary operator before token "("
./DerivedSources/webkit/WebKitDOMHTMLInputElement.h:168:5: warning: "ENABLE" is not defined
./DerivedSources/webkit/WebKitDOMHTMLInputElement.h:168:11: error: missing binary operator before token "("

Full results here:
https://webkit-commit-queue.appspot.com/results/3350339

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.