[Webkit-unassigned] [Bug 39843] [GTK] WebKitWebView should support drops

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39843





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2010-07-02 09:29:31 PST ---
(In reply to comment #3)

Thanks for the review! I've implemented all of your suggestions.

>  +  GdkDragAction dragOperationToGdkDragAction(DragOperation coreAction)
> I feel this name is way too similar to the other function. How about dragOperationToSingleGdkDragAction?
Done.

> WebCore/platform/gtk/ClipboardUtilitiesGtk.cpp:58
>  +      // to use it all applicable flags are on.
> I failed to parse this comment. s/use it/check/?
I changed this to: to use it when all applicable flags are on.

>  +      g_idle_add(reinterpret_cast<GSourceFunc>(doDragLeaveLater), priv->droppingContexts->get(context));
> I learned to not trust idles. They get starved, and we lose. Can
> we replace this with a g_timeout_add(0...) call instead? If not,
> I'd prefer to have a flag that you raise to say these actions are
> pending, and perform them after handling drag-drop (perhaps
> register the timeout at that point?).
Makes sense. g_timeout_add(0...) seems to work fine here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.