[Webkit-unassigned] [Bug 41413] [Qt] QtWebKit needs public API for Notifications.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41413





--- Comment #5 from Simon Hausmann <hausmann at webkit.org>  2010-07-02 05:28:54 PST ---
(From update of attachment 60152)
Some comments:

WebKit/qt/Api/qwebpage.h:303
 +      void setUserPermission(PermissionDomain, const QString&, PermissionPolicy);
In the Qt API we tend to always give names to the parameters.

WebKit/qt/Api/qwebpage.h:386
 +      void requestPermissionFromUser(QWebPage::PermissionDomain domain, const QString& origin);
I think in this API the origin parameter is significant and should come first. The same applies to the other functions.

The use of the origin as string is nice, that's nice. But is it very descriptive? Does it allow the UI on top of QtWebKit to provide enough information to the user? I wonder if these permissions can always be tied to a QWebFrame instead (as first parameter)?


Conceptually I think it would be nice if the API allowed the developer to react immediately if he wants to but he also
has the option of reacting later. Immediate reaction is useful for programmatic setups, like the DRT.

I like the approach of emitting a signal and I think it would be nice if in the slot all the parameters are in place
to make granting or denying the permissions a simple task. So an object as parameter that allows setting the permission
would achieve that, such as QWebFrame or a more specialized object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.