[Webkit-unassigned] [Bug 32509] [Qt] 3rd edition phones lack character echo in web input fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32509


Samuel Nevala <samuel.nevala at digia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|samuel.nevala at digia.com     |webkit-unassigned at lists.web
                   |                            |kit.org




--- Comment #38 from Samuel Nevala <samuel.nevala at digia.com>  2010-07-02 02:56:52 PST ---
if (!document()->page()->focusController()->focusedOrMainFrame()->editor()->hasComposition())    m_text.makeSecure(secureChar);

can be replaced with 

if(!(node() && document()->frame()->editor()->compositionNode() == node()))                m_text.makeSecure(secureChar);

and #include "FocusController.h" can be removed. Layer violation is there already if it is about document()->frame()->editor(). To me it seem pretty minor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.