[Webkit-unassigned] [Bug 41462] Move parseDataUrl() from CURL into ResourceHandle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41462


Patrick R. Gansterer <paroga at paroga.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60240|0                           |1
        is obsolete|                            |
  Attachment #60240|review?, commit-queue?      |
               Flag|                            |
  Attachment #60351|                            |review?, commit-queue?
               Flag|                            |




--- Comment #4 from Patrick R. Gansterer <paroga at paroga.com>  2010-07-02 01:40:37 PST ---
Created an attachment (id=60351)
 --> (https://bugs.webkit.org/attachment.cgi?id=60351)
Patch

(In reply to comment #3)
> (From update of attachment 60240 [details])
> I’m not so comfortable with putting this function into the cross platform file because it's used by two back ends. There are many other back ends that don't use it. Should the other back ends be using it too? Is there any other place we could put it?
It can be used by other backends too.
Maybe it can be used at http://trac.webkit.org/browser/trunk/WebCore/page/Page.cpp#L574 too?

> Naming the function "parse" seems wrong. Parsing is part of what it does, but it actually performs the loading as well. I think the name should be loadDataURL or handleDataURL. The word "parse" gives the sense of something that would output a parsed result, not something that would make actual loading-related calls to the client.
I didn't liked the name too. ;-)

> Calling latin1() twice on the same string seems like a mistake. That ends up allocating a CString twice.
I created an overload for base64Decode at bug 41510.

> What data URL test cases do we have?
DataURLs are tested indirect, because other test use it (e.g. embedding images).

Addressd the other points too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.