[Webkit-unassigned] [Bug 40835] Adds support for throwing behavior of SerializedScriptValue to be specified in the IDL.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40835


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60241|review?                     |review+
               Flag|                            |




--- Comment #39 from Jeremy Orlow <jorlow at chromium.org>  2010-07-02 00:33:12 PST ---
(From update of attachment 60241)
WebCore/bindings/scripts/test/JS/JSTestObj.cpp:833
 +      JSC::JSValue result =  ec ? jsUndefined() :  serializedScriptValue ? serializedScriptValue->deserialized() : jsNull();
Personally, I think this is cleaner:

if (ec) {
    setDOMException
    return jsUndefined;
}
return serializedScriptVlaue->deserilized()

WebCore/bindings/scripts/CodeGeneratorJS.pm:2475
 +      $ret = $ret . " serializedScriptValue ? serializedScriptValue->deserialized() : jsNull();\n";
you get double spaces between a few items here...not that big of a deal tho



r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.