[Webkit-unassigned] [Bug 40793] [GTK] The size of the shadow image uses the standard deviation size instead of the blur radius
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 1 13:25:24 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=40793
WebKit Review Bot <webkit.review.bot at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit.review.bot at gmail.com
--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com> 2010-07-01 13:25:25 PST ---
Attachment 60279 did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/graphics/filters/FEGaussianBlur.cpp:101: Should have a space between // and comment [whitespace/comments] [4]
WebCore/platform/graphics/filters/FEGaussianBlur.cpp:104: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebCore/platform/graphics/filters/FEGaussianBlur.cpp:113: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebCore/platform/graphics/filters/FEGaussianBlur.cpp:119: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebCore/platform/graphics/filters/FEGaussianBlur.cpp:121: One line control clauses should not use braces. [whitespace/braces] [4]
WebCore/platform/graphics/filters/FEGaussianBlur.cpp:126: GAUSSIAN_KERNEL_FACTOR is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/graphics/filters/FEGaussianBlur.cpp:182: Missing spaces around / [whitespace/operators] [3]
WebCore/platform/graphics/filters/FEGaussianBlur.cpp:183: Missing spaces around / [whitespace/operators] [3]
Total errors found: 8 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list