[Webkit-unassigned] [Bug 40807] [EFL] add support for logging

Thu Jul 1 12:00:53 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=40807

Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59457|review?                     |review-
               Flag|                            |

--- Comment #10 from Gustavo Noronha (kov) <gns at gnome.org>  2010-07-01 12:00:52 PST ---
(From update of attachment 59457)
WebCore/platform/efl/LoggingEfl.cpp:48
 +      char* logv = strtok(logEnv, " ");
This is wrong. strtok modifies the string it is given, while getenv returns a pointer to a string that is part of the actual environment, so modifying it modifies the environment. Isn't the EFL port using glib for some other stuff already? Why not share the same implementation with GTK+, since for now you're going with the same approach?

r- for the reason above; in a later patch you may want to set the commit-queue flag to ?, to indicate you wish it to be automatically committed, unless you want one of the committers to do it manually =)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.