[Webkit-unassigned] [Bug 40233] [Qt] Initial WebKit2 implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 1 07:20:03 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40233





--- Comment #22 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-07-01 07:20:02 PST ---
Attachment 60244 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/API/qt/qwkpage.cpp:21:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:24:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:27:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:176:  QWKPagePrivate::_q_webActionTriggered is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/UIProcess/API/qt/qgraphicswkview.h:7:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qgraphicswkview.h:8:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:21:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:48:  _q_scaleChanged is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:267:  QGraphicsWKViewPrivate::_q_scaleChanged is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:27:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:61:  _q_webActionTriggered is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 12 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list