[Webkit-unassigned] [Bug 40835] Adds support for throwing behavior of SerializedScriptValue to be specified in the IDL.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40835





--- Comment #37 from Marcus Bulach <bulach at chromium.org>  2010-07-01 07:01:53 PST ---
thanks jeremy! another look please?

(In reply to comment #34)
> (From update of attachment 60111 [details])
> WebCore/bindings/js/SerializedScriptValue.h:179
>  +          static PassRefPtr<SerializedScriptValue> createWithoutThrowing(JSC::ExecState* exec, JSC::JSValue value);
> don't need exec or value here...or below
done

> 
> WebCore/bindings/js/SerializedScriptValue.h:183
>  +          static PassRefPtr<SerializedScriptValue> create(JSC::ExecState* exec, JSC::JSValue value, ExceptionCode* ec);
> don't need ec
done.

> 
> WebCore/bindings/scripts/CodeGeneratorJS.pm:2234
>  +          push(@implContent, "\n" . NativeSerializedScriptValueToJSValue($function->signature, $functionString, @{$function->raisesExceptions})) if $function->signature->type eq "SerializedScriptValue";
> what about any?  be sure to test for this if it's true that you should have had "any"?
right, testing for both SerializedScriptValue and any.

> 
> WebCore/bindings/scripts/CodeGeneratorJS.pm:2473
>  +      if ($type eq "SerializedScriptValue" or $type eq "any") {
> Do you actually need this?  Can't you assume it?
good point.. changed so that the caller tests it.

> 
> WebCore/bindings/scripts/test/JS/JSTestObj.cpp:832
>  +      SerializedScriptValue* serializedScriptValue = imp->serializedValueReturnRaises(ec);
> Wouldn't this need to be a PassRefPtr?
done.

> 
> Does anything even use this code yet?  If not, then maybe we shouldn't test for it and/or worry about it.
well, I think it's better to have it now rather than worry about it later? as in, as far as i can tell it's a valid case and we want to make sure the generator will "do the right thing"?

> 
> WebCore/bindings/scripts/test/JS/JSTestObj.cpp:833
>  +      JSC::JSValue result = serializedScriptValue && !ec ? serializedScriptValue->deserialized() : jsNull();
> if ec is set, we should return undefined.  Otherwise null.
done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.