[Webkit-unassigned] [Bug 40233] [Qt] Initial WebKit2 implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40233





--- Comment #18 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-07-01 06:46:17 PST ---
Attachment 60239 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
Last 3072 characters of output:
e: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:24:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:33:  wtf includes should be <wtf/file.h> instead of "wtf/file.h".  [build/include] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:48:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:52:  _q_scaleChanged is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:271:  QWKGraphicsWidgetPrivate::_q_scaleChanged is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:21:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:24:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:27:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:137:  Declaration has space between type name and * in QAction *a  [whitespace/declaration] [3]
WebKit2/UIProcess/API/qt/qwkpage.cpp:178:  QWKPagePrivate::_q_webActionTriggered is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:180:  Declaration has space between type name and * in QAction *a  [whitespace/declaration] [3]
WebKit2/UIProcess/API/qt/qwkpage.cpp:338:  Declaration has space between type name and * in QAction *a  [whitespace/declaration] [3]
WebKit2/UIProcess/API/qt/qwkpage.h:1:  #ifndef header guard has wrong style, please use: qwkpage_h  [build/header_guard] [5]
WebKit2/UIProcess/API/qt/qwkpage_p.h:26:  wtf includes should be <wtf/file.h> instead of "wtf/file.h".  [build/include] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:27:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:28:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:61:  _q_webActionTriggered is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 28 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.