[Webkit-unassigned] [Bug 40233] [Qt] Initial WebKit2 implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 1 06:08:09 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=40233
--- Comment #9 from WebKit Review Bot <webkit.review.bot at gmail.com> 2010-07-01 06:08:08 PST ---
Attachment 60233 did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/Shared/qt/WebEventFactory.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/Shared/qt/WebEventFactory.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/qt/WebEventFactory.cpp:42: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
WebKit2/Shared/qt/WebEventFactory.cpp:54: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
WebKit2/Shared/qt/WebEventFactory.cpp:154: Extra space between int and nativeVirtualKeyCode [whitespace/declaration] [3]
Total errors found: 5 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list