[Webkit-unassigned] [Bug 5861] feConvolveMatrix filter is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5861





--- Comment #37 from Nikolas Zimmermann <zimmermann at kde.org>  2010-07-01 02:29:21 PST ---
(In reply to comment #36)
> ALWAYS_INLINE is a hammer we use when the compiler does the wrong thing.  It isn't just to be sprinkled around. :)  We add it for large functions which the compiler refuses to inline on its own.  Just placing something in a class definition (in a header) implicitly marks it "inline".  No need to add ALWAYS_INLINE unless we have demonstrated the compiler fails to comply.  It's better to let the compiler figure things out than to force its hand with ALWAYS_INLINE

Well, clearly the function should be inlined. I'd say better safe than sorry - and thus have no problem with the ALWAYS_INLINE usage. It's done like this in the other filter effects (lighting etc.) as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.