[Webkit-unassigned] [Bug 5861] feConvolveMatrix filter is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5861





--- Comment #35 from Nikolas Zimmermann <zimmermann at kde.org>  2010-07-01 02:09:45 PST ---
(From update of attachment 60210)
Great patch, thanks so much! r=me.

Please fix some last small issues before landing:

WebCore/svg/graphics/filters/SVGFEConvolveMatrix.h:92
 +      // Only once usage -> can be ALWAYS_INLINE
Just remove this comment, I don't think it helps much.

WebCore/svg/graphics/filters/SVGFEConvolveMatrix.h:96
 +      // Only once usage -> can be ALWAYS_INLINE
Ditto.

WebCore/svg/graphics/filters/SVGFEConvolveMatrix.h:98
 +      template<bool preserveAlphaValues>
Can you please add a newline between this template<bool> and the line before. Looks less cluttered.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.