[Webkit-unassigned] [Bug 41447] [GTK] Extra nullcheck needed at SelectionControllerGtk.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41447


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60209|0                           |1
        is obsolete|                            |
  Attachment #60213|                            |review?
               Flag|                            |




--- Comment #3 from Mario Sanchez Prada <msanchez at igalia.com>  2010-07-01 01:10:20 PST ---
Created an attachment (id=60213)
 --> (https://bugs.webkit.org/attachment.cgi?id=60213)
Patch proposal

(In reply to comment #2)
> (From update of attachment 60209 [details])
> I think doing:
> 
> if (!accessibilityObject)
>     return;
> 
> is much better.

Done.

> Also, we should look into why a NULL object is being created in the first place...

Agree, and I have the feeling is related to the rendering object not being created by that time, although that would be quite weir and would be indeed another bug for sure... In any case I think this null check doesn't hurt either.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.