[Webkit-unassigned] [Bug 5861] feConvolveMatrix filter is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5861





--- Comment #32 from Zoltan Herczeg <zherczeg at webkit.org>  2010-07-01 01:06:06 PST ---
I did your suggested changes. Thanks for the review.

> WebCore/svg/graphics/filters/SVGFEConvolveMatrix.cpp:231
>  +                  totals[0] += m_kernelMatrix[kernelValue] * static_cast<float>(paintingData.srcPixelArray->get(kernelPixel++));
> Would it help to store m_kernelMatrix[kernelValue] in a local variable? Not sure.

You mean copy the values to a local array? Not sure that will help.

> WebCore/svg/graphics/filters/SVGFEConvolveMatrix.cpp:244
>  +              paintingData.dstPixelArray->set(pixel++, clampRGBAValue(totals[0] / m_divisor + paintingData.bias));
> Is m_divisor guarenteed to be non null? If so please add an assertion on top of this function.

Added the assert and a comment. m_divisor cannot be 0, otherwise the filter will be not created.

> WebCore/svg/graphics/filters/SVGFEConvolveMatrix.cpp:355
>  +          fastSetInteriorPixels<true>(paintingData, clipRight, clipBottom);
> Just wondering, is it possible to use m_preserveAlpha directly as template parameter? I guess not :-)

Template arguments must be compile time constants.

I still not have expected pixel test for the generic mac, only for mac-leopard :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.