[Webkit-unassigned] [Bug 34380] [WINCE] Buildfix for ThreadSpecific.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34380


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47776|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-01-31 19:47:36 PST ---
(From update of attachment 47776)
> +// TLS_OUT_OF_INDEXES is not defined on WinCE.
> +#ifndef TLS_OUT_OF_INDEXES
> +#define TLS_OUT_OF_INDEXES 0xffffffff
> +#endif

I guess this is OK, but I don't see any check for WinCE here. Might be slightly
better to explicitly use a WINCE ifdef so we’d get a warning instead of just
using the wrong value if someone made a mistake and did not get the
TLS_OUT_OF_INDEXES constant.

> -    DWORD tls_key = TlsAlloc();
> -    if (tls_key == TLS_OUT_OF_INDEXES)
> +    DWORD tlsKey = TlsAlloc();
> +    if (tlsKey == TLS_OUT_OF_INDEXES)
>          CRASH();
>  
>      m_index = InterlockedIncrement(&tlsKeyCount()) - 1;
>      if (m_index >= kMaxTlsKeySize)
>          CRASH();
> -    tlsKeys()[m_index] = tls_key;
> +    tlsKeys()[m_index] = tlsKey;

The unrelated style change really does not belong on the same patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.