[Webkit-unassigned] [Bug 33953] [Android] Android lacks V8 equivalent of JavaStringJSC.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33953


Ariya Hidayat <ariya.hidayat at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47698|review?                     |review+
               Flag|                            |




--- Comment #2 from Ariya Hidayat <ariya.hidayat at gmail.com>  2010-01-31 15:57:06 PST ---
(From update of attachment 47698)

> +        const char* cs = getCharactersFromJStringInEnv(e, s);
> +        {
> +            m_utf8String = WebCore::CString(cs, size);
> +        }

Minor nitpick: since we don't need JSLock here, do we need to put that line in
its own block?

Otherwise, LGTM.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.