[Webkit-unassigned] [Bug 33750] Add back an AffineTransform class for use by SVG
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 31 11:31:33 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=33750
--- Comment #8 from WebKit Review Bot <webkit.review.bot at gmail.com> 2010-01-31 11:31:32 PST ---
Attachment 47795 did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Last 3072 characters of output:
ontextSkia.cpp:821: One space before end of line comments
[whitespace/comments] [5]
WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:822: One space before
end of line comments [whitespace/comments] [5]
WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:823: One space before
end of line comments [whitespace/comments] [5]
WebCore/platform/graphics/skia/TransformationMatrixSkia.cpp:31: Found other
header before a header this file implements. Should be: config.h, primary
header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebCore/platform/graphics/cairo/PathCairo.cpp:333: c_matrix is incorrectly
named. Don't use underscores in your identifier names. [readability/naming]
[4]
WebCore/platform/graphics/transforms/AffineTransform.cpp:118: Tests for
true/false, null/non-null, and zero/non-zero should all be done without
equality comparisons. [readability/comparison_to_zero] [5]
WebCore/platform/graphics/transforms/AffineTransform.cpp:119: Tests for
true/false, null/non-null, and zero/non-zero should all be done without
equality comparisons. [readability/comparison_to_zero] [5]
WebCore/platform/graphics/transforms/AffineTransform.cpp:129: Tests for
true/false, null/non-null, and zero/non-zero should all be done without
equality comparisons. [readability/comparison_to_zero] [5]
WebCore/platform/graphics/transforms/AffineTransform.cpp:135: Tests for
true/false, null/non-null, and zero/non-zero should all be done without
equality comparisons. [readability/comparison_to_zero] [5]
WebCore/platform/graphics/qt/TransformationMatrixQt.cpp:27: Found other header
before a header this file implements. Should be: config.h, primary header,
blank line, and then alphabetically sorted. [build/include_order] [4]
WebCore/platform/graphics/cg/TransformationMatrixCG.cpp:27: Found other header
before a header this file implements. Should be: config.h, primary header,
blank line, and then alphabetically sorted. [build/include_order] [4]
WebCore/platform/graphics/wx/TransformationMatrixWx.cpp:27: Found other header
before a header this file implements. Should be: config.h, primary header,
blank line, and then alphabetically sorted. [build/include_order] [4]
WebCore/platform/graphics/cairo/TransformationMatrixCairo.cpp:26: Found other
header before a header this file implements. Should be: config.h, primary
header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebCore/platform/graphics/cairo/TransformationMatrixCairo.cpp:50:
cairo_matrix_t is incorrectly named. Don't use underscores in your identifier
names. [readability/naming] [4]
WebCore/platform/graphics/cairo/TransformationMatrixCairo.cpp:54: Extra space
before ( in function call [whitespace/parens] [4]
WebCore/platform/graphics/transforms/AffineTransform.h:130: Missing spaces
around *= [whitespace/operators] [3]
WebCore/platform/graphics/transforms/AffineTransform.h:147: cairo_matrix_t is
incorrectly named. Don't use underscores in your identifier names.
[readability/naming] [4]
Total errors found: 19
If any of these errors are false positives, please file a bug against
check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list