[Webkit-unassigned] [Bug 34317] [GStreamer] Add a WebKit HTTP/HTTPS source that uses WebKit's network infrastructure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34317





--- Comment #9 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-01-30 03:05:58 PST ---
Attachment 47764 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Last 3072 characters of output:
eadability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:452: 
webkit_web_src_uri_set_uri is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:457:  An else if
statement should be written as an if statement when the prior "if" concludes
with a return, break, continue or goto statement.  [readability/control_flow]
[4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:460:  Extra space
before ( in function call  [whitespace/parens] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:465:  Extra space
before ( in function call  [whitespace/parens] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:471: 
webkit_web_src_uri_handler_init is incorrectly named. Don't use underscores in
your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:483: 
webkit_web_src_need_data_main_cb is incorrectly named. Don't use underscores in
your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:496: 
webkit_web_src_need_data_cb is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:508: 
webkit_web_src_enough_data_main_cb is incorrectly named. Don't use underscores
in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:520: 
webkit_web_src_enough_data_cb is incorrectly named. Don't use underscores in
your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:532: 
webkit_web_src_seek_main_cb is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:540: 
webkit_web_src_seek_data_cb is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:563: 
webkit_web_src_set_frame is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:614:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:627:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:634:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:641:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:648:  Use 0 instead
of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:678:  One line
control clauses should not use braces.  [whitespace/braces] [4]
WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:145:  Tab found;
better to use spaces  [whitespace/tab] [1]
Total errors found: 45


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.